Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump adaptivecards@2.5.0 #3630

Merged
merged 10 commits into from
Dec 15, 2020
Merged

Bump adaptivecards@2.5.0 #3630

merged 10 commits into from
Dec 15, 2020

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Dec 8, 2020

Fixes #3392

Changelog Entry

Description

Tests image diffs updated

There are a number of tests that had to be updated with this bump. I have verified the behavior as either a fix of Adaptive Cards behavior, regression (with corresponding issue), or trivial changes due to MockBot updates.

'adaptive cards broken card of invalid version'

image
This error message is from the Adaptive Cards sdk
This is a change in behavior to what should be expected. Broken card should show an error, not show an empty div.

'useScrollToEnd calling scroll to end should scroll to end'

image

There are a number of scrollbar fixes (due to length of transcript)that are caused by adding new commands to MockBot. This is not a change in behavior.

'clock skew - faking clock skew should affect activity order'

image

Previously, images were not center-aligned even though MockBot's BingSports card indicates it. Fixed by Adaptive Cards bump.

'adaptive cards disable card inputs'

image
This is a behavior bug from Adaptive Cards, seen at microsoft/AdaptiveCards#5134 This PR shows the change as fixed, and therefore should be fixed in the next AC release/bump. This will eventually mean updating the snapshots again.

'transcript activity grouping'
These screenshots are additions, not changes. I'm assuming they are new tests that didn't have snapshots pushed up in a previous commit. I am assuming the behavior in these screenshots is as expected

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • [ ] I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@corinagum corinagum changed the title [DRAFT] Bump adaptivecards@2.5.0 Bump adaptivecards@2.5.0 Dec 8, 2020
@corinagum corinagum marked this pull request as ready for review December 8, 2020 22:56
@corinagum
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Adaptive Cards to 2.*
3 participants